Unit tests for location_table access pattern#29
Merged
rockdaboot merged 2 commits intoelastic:mainfrom Jul 8, 2025
Merged
Conversation
rockdaboot
reviewed
Jul 3, 2025
Contributor
Author
|
@rockdaboot is this good to go? |
rockdaboot
approved these changes
Jul 8, 2025
Contributor
rockdaboot
left a comment
rockdaboot
left a comment
There was a problem hiding this comment.
Thanks for working on it, lgtm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed under #27, I'm adding some unit tests for the updated access pattern to
location_table.I introduced a new function
collect_frame_listwhose job is to access the proper indexes inlocation_tableand build aVec<Frame>. I made it a generic to simplify writing unit tests.